search

folklabs / communitydata

Promoting the use of open data by the community.
GNU General Public License v2.0
3 stars 1 forks source link

Vis builder - filtering datasets #105

Closed GilesGibson closed 10 years ago

GilesGibson commented 10 years ago

live site logged on as gilesgibson

Now that we have a few datasets to choose from, there is no way of filtering or searching for them apart from scrolling down. There used to be a search on name at some stage way back. Can we add back in?

pmackay commented 10 years ago

Fixed on live.

GilesGibson commented 10 years ago

Great, nifty addition. It is good that it filters as you type, like that. If you hit enter after the search text though it creates a new vis with no dataset selected (I think). May cause usability issues.

pmackay commented 10 years ago

Done quick investigation, problem is the whole wizard is part of a Drupal form, so pressing Enter makes Drupal think you're submitting the form. Dont think I can do a quick fix tonight, unless its hiding the filter text box for now.

GilesGibson commented 10 years ago

OK, add to backlog.

pmackay commented 10 years ago

@GilesGibson I've added a fix that disables Enter when using the form. Please check.

GilesGibson commented 10 years ago

looks good, thanks