search

folklabs / communitydata

Promoting the use of open data by the community.
GNU General Public License v2.0
3 stars 1 forks source link

Right hand column in vis details - not aligning #116

Closed GilesGibson closed 10 years ago

GilesGibson commented 10 years ago

live site logged on as gilesgibson

The right hand column of vis data doesn't align correctly - as soon as there is some text wrap on the line the next vis right hand tab is wrong - too far to the left. The text that is affected is the "type" and author text.

image

djwesto commented 10 years ago

Just pushed a fix for this issue to dev- efffead10e70e171f03df2b109a02f2eb8df40db

@GilesGibson please check at http://dev-communitydata.gotpantheon.com/visualizations then confirm completion:

image

GilesGibson commented 10 years ago

should the stars not be alongside the "Rated" text

djwesto commented 10 years ago

It would be great if they could but there's a very complex bit of work going on there to drive the ratings stars. For instance, in other instances, the display shows an average number of votes after the stars themselves...

So I'd need Paul to look at how they're being generated if you want to have those displayed inline. @pmackay, any chance you could just take a look under the hood and see if you can figure out how to get that fivestar stars block to run in next to the "Rated:" text?

djwesto commented 10 years ago

@GilesGibson while we're waiting to hear from Paul, please could you confirm whether you're generally happy with the rest of the work I've done? Ta.

GilesGibson commented 10 years ago

the alignment stuff looks great, starting to look a bit neater. Thanks.

GilesGibson commented 10 years ago

when will this migrate across to the live site?

djwesto commented 10 years ago

@pmackay please could you push the new code to -live some time today? I don't want to do it as I'm not sure if the other code on dev has been tested adequately yet.

pmackay commented 10 years ago

Fixed on live. Closing.