folklabs / communitydata

Promoting the use of open data by the community.
GNU General Public License v2.0
3 stars 1 forks source link

Fix linking to internal pages with Linkit in TinyMCE - breaking interface #122

Closed djwesto closed 10 years ago

djwesto commented 10 years ago

Logged into LIVE on Pantheon as: admin

I was editing /mentors page content in HTML mode at: http://live-communitydata.gotpantheon.com/node/28/edit#

I tried to select the word "Contact" on the last line of text and clicked the Linkit URL (chain) icon on the TinyMCE toolbar to make a link.

A modal panel appeared allowing me to type in a page name I want to link to. I typed "conta" and saw "contact" appear in the dropdown so I clicked that and added other text to the remaining fields then clicked Insert Link but nothing happened and clicking Cancel didn't work either. image

After a couple more clicks I was then taken thru to this unstyled page: http://live-communitydata.gotpantheon.com/linkit/dashboard/tinymce

image CHECKLIST:

pmackay commented 10 years ago

@djwesto I've pushed the latest dev version of linkit to test - could you check it?

djwesto commented 10 years ago

No, it's not really working for me still, although I do wonder if it's partly because of the unclear interface text the module uses. I select some text, click the Linkit button then try typing in a known content page title such as "about" – the spinner doesn't spin and nothing happens...

Logged into TEST on Pantheon as: admin

I just ran a test again at http://test-communitydata.gotpantheon.com/node/28/edit (the Mentors page)

This time I found that while it's now possible to click the Insert link, I was still taken through to the unstyled page at http://test-communitydata.gotpantheon.com/linkit/dashboard/tinymce where the Insert link buttons still didn't function. Am I perhaps entering some incorrect information into the fields?

image

After reaching that page I can't go anywhere apart from back to the previous page where no link has been added.

I assume we're using Linkit because it helps users add links from within the site more easily?

Don't suppose it's anything to do with this bug by any chance? https://www.drupal.org/node/2309939

pmackay commented 10 years ago

I think its another problem caused by needing to use jQuery >= v1.9. I was using v1.7 locally, so it worked ok.

We use Linkit because it comes by default with Panopoly. Looks like Panopoly and Bootstrap theme are just not that compatible currently.

pmackay commented 10 years ago

Raised https://www.drupal.org/node/2329103.

pmackay commented 10 years ago

Fixed on live with move to new theme.