Major style cleanup and full deprecation of Future#memoise

folktale / data.task

Migrating to https://github.com/origamitower/folktale

MIT License

425 stars 45 forks source link

Major style cleanup and full deprecation of Future#memoise #19

Closed L8D closed 9 years ago

L8D commented 9 years ago

Now the code is using completely unbound functions and follows a stricter JavaScript style. If you don't like the style, you can go in and change it, but I've added a jshintrc so be sure to edit that to your liking and preserve the semicolons.

robotlolita commented 9 years ago

Sorry for the delay in handling this PR. I'd like to write a few benchmarks before merging :x

L8D commented 9 years ago

do you want me to write them or are you going to handle that?

L8D commented 9 years ago

BTW, I wrote the proph module for personal use a few weeks ago, and this PR essentially makes the same changes. So you can benchmark with that too

robotlolita commented 9 years ago

Oh, okay. I'm thinking of having it written by this weekend.

L8D commented 9 years ago

…bump…

robotlolita commented 9 years ago

Thanks for taking your time to write this, and sorry for taking so long to merge it :x