Rewrote `ap` to be parallel instead of using sequential `chain`

folktale / data.task

Migrating to https://github.com/origamitower/folktale

MIT License

425 stars 45 forks source link

Rewrote `ap` to be parallel instead of using sequential `chain` #33

Closed safareli closed 8 years ago

safareli commented 8 years ago

If you have Array of Tasks and want transform it into Task of Array using traverse or sequence, tasks will be forked sequentially instead of parallel. The reason is that ap is implemented using sequential chain method. Here it is rewritten to be parallel.

safareli commented 8 years ago

Adopted from #32

DrBoolean commented 8 years ago

Sooo much nicer @safareli thanks!

DrBoolean commented 8 years ago

@robotlolita shall we pull the trigger here?

safareli commented 8 years ago

Welcome! I started using Task after your classroom coding videos so thank you too!

safareli commented 8 years ago

@robotlolita could you take a look at this PR

robotlolita commented 8 years ago

Sorry for taking so long to review :<

Anyway, just needs fixing the issue with reject and it's good to merge :)

(I also just realised this project doesn't have unit tests. I'll try to fix it this weekend, if I have some time)

safareli commented 8 years ago

@robotlolita fixed that issues you pointed out:

resolve is not called if Task is rejected
reject is called once

robotlolita commented 8 years ago

Thankies :)

Edit: It's released in v3.1.0

safareli commented 8 years ago

Nice :3