search

folletto / Blipshot

Google Chrome Extension to make screenshots
intenseminimalism.com
114 stars 19 forks source link

Avoid crashing on large screenshot using blob URL #1

Closed ble closed 12 years ago

ble commented 12 years ago

I've been participating in the discussion over at Chrome issue 69227 and I was curious to try using blobURLs in an actual application. Lacking one myself, I found yours. :)

I tested taking a screenshot of the WHATWG living Canvas standard on Chrome 17.0.963.46 on OS X 10.7.2. Prior to this change, a 1422 x 36724 pixel screenshot of crashed on drag and drop; post-change, the drag and drop succeeded, making a 9.3MB png.

folletto commented 12 years ago

@ble I'm speechless. Really. Thanks! :D

It's a simple merge, but... just give me some time, I just got off a plane and it's 00:26 now. I'll look into it asap. :)

folletto commented 12 years ago

Tested, it works great. :)

Thanks. :)

folletto commented 12 years ago

Updated, thanks. :) https://chrome.google.com/webstore/detail/mdaboflcmhejfihjcbmdiebgfchigjcf

folletto commented 12 years ago

I noticed that this fix blocked the correct propagation of the image title to the filename (it used the alt="" attribute). I had to create a workaround to this using the dragstart event and dataTransfer.setData (in screenshotter.DOM.js, function screenshotReturn).