folletto / Blipshot

Google Chrome Extension to make screenshots
intenseminimalism.com
114 stars 19 forks source link

Screenshot with on Chrome and github.com #22

Open nuthinking opened 4 years ago

nuthinking commented 4 years ago

For work I have to screenshot often github.com and most of the time the screenshot is like 15px thinner than the window (cropping on the right). How can I debug/help? Thanks!

folletto commented 4 years ago

That's intentional. Chrome hasn't yet provided the ability to screenshot the whole height, so the engine has to do some guesses and "remove" the scrollbar from the screenshot.

This is the code:

It's possible that Chrome updated the way screenshots are generated, by already not counting the scrollbar in the calculations. I've to look into that.

folletto commented 4 years ago

Using "Show Scroll Bar" is an easy way to see the problem.

Compare this: Screenshot 2020-05-08 at 10 27 21

To this: Screenshot 2020-05-08 at 10 27 32

nuthinking commented 4 years ago

So I guess it has the right width when there is no scrolling. Changing that option didn't work for me, but I have overlay scrollbars (and using a trackpad).

Screenshot 2020-05-08 at 15 02 01

folletto commented 4 years ago

You have to switch to "Always" to see it if you're using a trackpad, yes.

folletto commented 4 years ago

Note: it has the right with either:

  1. When there's no scrolling
  2. When the scrollbar is visible (either "Always" or "Automatically" + corded mouse)

It doesn't when it's a trackpad.

I haven't found a way to detect that scenario. If you've an idea, it's welcome :)