search

folletto / Blipshot

Google Chrome Extension to make screenshots
intenseminimalism.com
114 stars 19 forks source link

Chrome 92 broke capture of more than 2 scrolls #25

Closed folletto closed 3 years ago

folletto commented 3 years ago

Error:

Unchecked runtime.lastError: This request exceeds the MAX_CAPTURE_VISIBLE_TAB_CALLS_PER_SECOND quota.

Introduced in Chrome 92:

Apparently Chrome was crashing when screen was captured too fast, so they just decided to throttle it.

I wonder when we're finally going to get a proper full page API, but for the time being, let's again look for another workaround...

Thanks to JTL for the report.

folletto commented 3 years ago

The issue is being discussed here: https://bugs.chromium.org/p/chromium/issues/detail?id=1205278

folletto commented 3 years ago

I introduced 500ms throttling instead of 100ms which allows the extension to work in the limit of "2 captures per second", but it still feels quite wonky: https://github.com/folletto/Blipshot/commit/7ad4299100711769ff9ff20f6e7b15f49df40849

folletto commented 3 years ago

The issue is fixed. As much as I consider this a "bad fix" I also don't have a better workaround so I'm closing this for now. I feel this is going to come back...