manage chrome 34.0.1847.11 issue

nunziofiore commented 10 years ago

Image doesn't start with perms wrote as:

:///*

or similar.

U have to do like

https://github.com/otiai10/capture-bug-in-chrome34/commit/8fd72037b95230c121f4ce91a4ab012562795254

folletto commented 10 years ago

Thanks, I'll look into it. :)

Some additional reference:

https://developer.chrome.com/extensions/match_patterns (about <all_urls>)
https://developer.chrome.com/extensions/content_scripts
https://developer.chrome.com/extensions/activeTab (probably not doable, have to check)
https://codereview.chromium.org/140433003 (the bug started here + discussion)

folletto commented 10 years ago

Should be fixed with commit 4b951960c35bfb54bd01a867917887ef2a202e92. I also added a notification if a similar error happens again.

Given the changes happened since the first version of the extension it might be possible there's a better, more tighter way to handle the permissions, but I haven't found a clear way to do it. I need more time to do some research and testing, it might be possible to avoid broad permissions and just inject the code when needed. Not sure.

I've pushed version 1.0.6 update to the store. It should be live soon.

NOTE: unfortunately changing permission will require the extension to be re-enabled. :(

folletto / Blipshot

manage chrome 34.0.1847.11 issue #9