search

follmann / favicon_maker

Create favicon files in various sizes from a base image for ruby projects
MIT License
70 stars 7 forks source link

Fix `extend Forwardable` for Ruby 2.1.0 #13

Closed le0pard closed 10 years ago

le0pard commented 10 years ago 
2.1.0p0 :001 > require 'favicon_maker'
NameError: uninitialized constant FaviconMaker::Generator::Forwardable
    from /Users/leo/.rvm/gems/ruby-2.1.0/gems/favicon_maker-1.1/lib/favicon_maker/generator.rb:12:in `<class:Generator>'
    from /Users/leo/.rvm/gems/ruby-2.1.0/gems/favicon_maker-1.1/lib/favicon_maker/generator.rb:11:in `<module:FaviconMaker>'
    from /Users/leo/.rvm/gems/ruby-2.1.0/gems/favicon_maker-1.1/lib/favicon_maker/generator.rb:3:in `<top (required)>'
    from /Users/leo/.rvm/rubies/ruby-2.1.0/lib/ruby/site_ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require'
    from /Users/leo/.rvm/rubies/ruby-2.1.0/lib/ruby/site_ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require'
    from /Users/leo/.rvm/gems/ruby-2.1.0/gems/favicon_maker-1.1/lib/favicon_maker.rb:2:in `<top (required)>'
    from /Users/leo/.rvm/rubies/ruby-2.1.0/lib/ruby/site_ruby/2.1.0/rubygems/core_ext/kernel_require.rb:135:in `require'
    from /Users/leo/.rvm/rubies/ruby-2.1.0/lib/ruby/site_ruby/2.1.0/rubygems/core_ext/kernel_require.rb:135:in `rescue in require'
    from /Users/leo/.rvm/rubies/ruby-2.1.0/lib/ruby/site_ruby/2.1.0/rubygems/core_ext/kernel_require.rb:144:in `require'
    from (irb):1
    from /Users/leo/.rvm/rubies/ruby-2.1.0/bin/irb:11:in `<main>'
follmann commented 10 years ago

Snap! you don't use Bundler for your project do you? In the resque project this apparently also slipped through the tests, because Bundler required the module. Thanks!

le0pard commented 10 years ago

Thanks! I using Bundler, I just try to figure out this error: https://github.com/follmann/middleman-favicon-maker/issues/22 but not found right now.

follmann commented 10 years ago

Weird I couldn't reproduce both issues you filed. Just installed 2.1 this morning and reinstalled the bundled gems. But it's all fine...