Closed Arcovion closed 10 years ago
Can't you just set f.output_dir = <absolute-path>
? I actually don't want to include this logic in the extension. Therefore template_dir
and output_dir
require absolute paths.
Yes, f.output_dir = config[:build_dir]
works and I can use a relative path for f.template_dir
as expected - but it still doesn't remove the favicon_template.png
if f.template_dir
is changed.
I think some stuff like f.output_dir = config[:build_dir]
should be a default within the extension logic itself...
3.5.2: Issues persist
This line: f.output_dir = config[:build_dir]
is still required
Favicon not being removed and also not showing removal message
Steps to recreate:
set :build_dir 'C:/build'
f.template_dir 'source/assets'
Issues:
f.output_dir = config[:build_dir]
C:/build/assets
Errors from https://github.com/follmann/middleman-favicon-maker/issues/17 have cropped up again, suggest editing extension.rb similar to this:
The
builder.remove_file
is also pointing to the wrong place as before, surely it's best to cover this with middleman's built-in behaviour by just putting an underscore in front of thefavicon_template.png
?