foltik / vyos-client-go

VyOS Router HTTP API Client in Go (WIP)
MIT License
4 stars 6 forks source link

Code coverage #11

Open foltik opened 1 year ago

foltik commented 1 year ago

Integration testing was implemented with https://github.com/Foltik/vyos-client-go/commit/9b9a46c4ab7257a0e4fc459f7c1fd7628278a648.

It would be nice to have a code coverage report to go along with this.

jtcarnes commented 1 year ago

@foltik would you consider using something like codecov for coverage? Free for FOSS and integrates well with GH. Happy to make MR with it or whatever tool you prefer.

foltik commented 1 year ago

Sure! I've gone through the setup here and added a CODECOV_TOKEN repo secret.

Looks like we just need to update the makefile to emit coverage and add:

- name: Upload coverage reports to Codecov
  uses: codecov/codecov-action@v3
    env: CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}