fix(libs): upgraded libs, removed unused libs

fomantic / Fomantic-UI-Docs

Official Documentation for Fomantic-UI

https://fomantic-ui.com

28 stars 83 forks source link

fix(libs): upgraded libs, removed unused libs #284

Closed lubber-de closed 3 years ago

lubber-de commented 3 years ago

Description

This PR upgrades some js libs to current versions and removes unused libs. I also fixed unreadable clipboard notices and will now show a toast instead.

Upgrades

jquery 3.4.1 -> 3.6.0
clipboard 1.5.2 -> 2.0.8
less 3.9.0 -> 3.13.1

Removed

cookie
sinon
detectadblock

Screenshot

toastclipinfo

exoego commented 3 years ago

How about using free CDN instead of self-hosting ? https://www.jsdelivr.com/

CDN reduce the lines of codes to be included in repo. It also provide the resource integrity hash which is good in terms of security.

Something like this:

<script src="https://cdn.jsdelivr.net/npm/jquery@3.6.0/dist/jquery.min.js" 
        integrity="sha256-/xUj+3OJU5yExlq6GSYGSHk7tPXikynS7ogEvDej/m4="
        crossorigin="anonymous"></script>

lubber-de commented 3 years ago

Basically ok, but I think the idea is/was to keep the github docs pages autarchic.

Anyway, i would prefer to cleanup that and even more with a separate PR (the docpad layout files are quite messy....) It would also need some adjustments in the docs.js. For example a legacy version of jquery is used . So it's more than just replacing some URLs by CDN equivalents.