search

fomantic / Fomantic-UI-Docs

Official Documentation for Fomantic-UI
https://fomantic-ui.com
28 stars 85 forks source link

[fomantic-ui.com] Better searching on the fomantic-ui.com website on the icons page #316

Closed arethk closed 2 years ago

arethk commented 2 years ago

Go to this link: https://fomantic-ui.com/elements/icon.html

With the browsers search feature, try searching for "folder". It shows 0 hits.

Go to the semantic version: https://semantic-ui.com/elements/icon.html

With the browsers search feature, try searching for "folder". It shows 26 hits.

I see the "Search icons ..." text box but I don't want to use that. It would be nice to be able to use the browser search and then see what other icons are related to my search. Thanks.

lubber-de commented 2 years ago

Moving to Docs repo

exoego commented 2 years ago

Hmm, searching "folder" on FUI shows many icons for me.

exoego commented 2 years ago

ah, browser search... sorry 🤭

lubber-de commented 2 years ago

Very strange.... CTRL+F only finds visible (scrolled into viewport) content altough there is no lazy loading , so the whole DOM is already existing 🤔

lubber-de commented 2 years ago

Found it, because of performance reasons (?) the following commit once implemented a feature to hide non visible categories. Thereforce CTRL+F does not find them when not shown in the current viewport

https://github.com/fomantic/Fomantic-UI-Docs/commit/04193bd5a64f8df0a721fcb4a69c5953e95f75d0

@hammy2899 The only solution i see is to revert the particular checkVisibility codelogic, you once implemented. Opinion?

lubber-de commented 2 years ago

Fixed by #317