fomantic / Fomantic-UI-Docs

Official Documentation for Fomantic-UI
https://fomantic-ui.com
28 stars 84 forks source link

about overlay nag component #400

Closed 332lfgb6 closed 1 year ago

332lfgb6 commented 1 year ago

Bug Report

Click the close icon,overlay nag does not disappear, In other cases, clicking the close icon makes the nag disappear immediately

Steps

  1. click close icon

Expected result

clicking the close icon makes the nag disappear immediately

Actual result

Click the close icon,nag does not disappear

Screenshot (if possible)

image

Version

2.9.0

lubber-de commented 1 year ago

Moving to docs repo

lubber-de commented 1 year ago

Fixed by #401

332lfgb6 commented 1 year ago

Fixed by #401

I read your commit, but I still can't use itπŸ˜γ€‚γ€‚ Another problem is that other overlay nag is hidden by default and must be displayed through js, but this overlay nag is displayed by default.

<script src="https://cdn.jsdelivr.net/npm/jquery@3.6.1/dist/jquery.min.js"></script>
<link rel="stylesheet" type="text/css" href="https://cdn.jsdelivr.net/npm/fomantic-ui@2.9.0/dist/semantic.min.css" />
<script src="https://cdn.jsdelivr.net/npm/fomantic-ui@2.9.0/dist/semantic.min.js"></script>

<div class="ui segment">
  <div class="ui overlay nag">
    <div class="title">Welcome to the nag module</div>
    <div>Look, I am a top overlay nag!</div>
    <i class="close icon"></i>
  </div>
  <p>12345678</p>
  <p>12345678</p>
  <p>12345678</p>
  <p>12345678</p>
  <p>12345678</p>
  <p>12345678</p>
  <p>12345678</p>
</div>
<!--I don't even need to write this code-->
<!--I don't even need to write this code-->
<!--I don't even need to write this code-->
<button id="btn">button</button>
<script>
  $(document).ready(() => {
    $('#btn').click(() => {
      $('.ui.nag').nag()
    })
  })
</script>

How should I change the code?

image

lubber-de commented 1 year ago

Thanks, that is now fixed by https://github.com/fomantic/Fomantic-UI/pull/2552