fomantic / Fomantic-UI

Fomantic-UI is the official community fork of Semantic-UI
https://fomantic-ui.com
MIT License
3.52k stars 329 forks source link

[Cards] Even column count cards bug #3037

Closed wdmeest closed 2 months ago

wdmeest commented 2 months ago

Bug Report

When you add an even number of columns to the cards group, that is within a grid div, the number of cards in a row does not match the number of columns of the cards group

Steps to reproduce

1.Create grid element with two columns, example one with a twelve wide and four wide column

  1. Add cards group (with an even number of column count, example two, four, six, ...) within the grid column element

Expected result

When card column count is four, we expect to see 4 cards on one row

Actual result

When card column count is four, we see 3 cards on one row

Testcase

https://jsfiddle.net/91rcvu7e/

Version

2.9.3

GammaGames commented 2 months ago

I see it in Firefox (it's also really flickery when you resize the window): image

But not Chrome: image

Weird!

lubber-de commented 2 months ago

This also happens when not using FUI. Firefox seems to wrongly calculate the width calc(25% - 1em) in some cases. I filed an issue using a minimum html/CSS example at https://github.com/webcompat/web-bugs/issues/136609

Minimal test case without FUI https://jsfiddle.net/lubber/qcght26s/9/

lubber-de commented 2 months ago

I just tried the same jsfiddle using an older firefox version (115) and the issue does not exist there, so it's definately something the firefox developers have to fix

lubber-de commented 2 months ago

Closing for now as i dont know how to fix this inside FUI until FF fixes it in their engine (just removing the - 1em from the calc function would mess up the whole margins... just tried

lubber-de commented 2 months ago

I also filed a bug at https://bugzilla.mozilla.org/show_bug.cgi?id=1895485

lubber-de commented 2 months ago

Issue is fixed in next Firefox Release

wdmeest commented 2 months ago

Thxs for the follow up!