fix(form) duplicate error displays on invalid form field value

[BrianJavier99]

Description

Adds a variable formErrorsTracker that tracks which field identifiers have already pushed an error prompt in the formErrors variable which limits the number of error prompt for every field identifier into 1.

Test

https://jsfiddle.net/94oer63c/

Screenshot (if possible)

Closes

2923

[BrianJavier99]

Thanks, it basically works, but the extra newIdentifier check isn't needed. Please see my comments

Hello @lubber-de, the reason why I added a newIdentifier variable is to avoid an error popping up in the console:

When I investigated the root cause, I discovered the cause being the call to module.add.prompt() have the fieldErrors variable as an argument, which was empty since we now check if the error prompt is a duplicate before pushing it to the fieldErrors array.

This means that while nothing will be concatenated to the formErrors array, the subsequent lines, module.add.prompt and settings.onInvalid.call, will still also be called with null or empty arguments and will prompt errors.

However while typing this out, I have thought out of a better implementation, which is to check if the fieldErrors array has no content instead.

[BrianJavier99]

@lubber-de , sorry for the delay. With my recent commits I have tried addressing the cases that you have specified.

Below are the new behaviors.

Not Inline, error limit 0:

Not Inline, error limit 1:

Inline, error limit 0:

Inline, error limit 1:

Please let me know if I have missed any scenario or failed to consider a certain feature/functionality. Thank you.

[lubber-de]

Please fix the linting issues 😉

[BrianJavier99]

While fixing linting issues, I have encountered some bugs:

A formerly valid field does not display the error prompt once it becomes invalid again:

Conversely, a formerly invalid field does not remove the error prompt once it becomes valid again:

Will try to fix these issues within this week.

[BrianJavier99]

Hello again @lubber-de,

I was only able to get back on this today. It seems that the issue I have previously discovered arose due to the fact that the error prompts are added/removed to the field groups as a whole and it lacks the functionality to iterate on every field with a similar identifier. This issue is unrelated from this issue and is replicable in the develop branch (I have used your fiddle).

I propose that we put the issue into another ticket and proceed with the merging of this PR should there be no other concerns anymore.

Please let me know what you think, thanks.