Themes always installed regardless of config

neutraali commented 5 years ago

We don't want/need any separate themes into our library folder, so following the docs we set up our semantic.json setup as follows:

  . . .
  "themes": {
    "amazon": false,
    "basic": false,
    "bookish": false,
    "bootstrap3": false,
    "chubby": false,
    "classic": false,
    "colored": false,
    "duo": false,
    "fixed-width": false,
    "flat": false,
    "github": false,
    "gmail": false,
    "instagram": false,
    "material": false,
    "pulsar": false,
    "raised": false,
    "resetcss": false,
    "round": false,
    "rtl": false,
    "striped": false,
    "timeline": false,
    "default": true
  }

Beforehand, I made sure that semantic-ui/src/themes was empty and then ran: gulp --gulpfile node_modules/fomantic-ui/gulpfile.js install.

Expected outcome: Only default theme is installed. Actual outcome: All themes are installed.

Are the docs outdated or is our config faulty? Am I running the wrong commands? Not really a show-stopping bug but confusing each time I look at the themes folder.

ColinFrick commented 5 years ago

Are you using Meteor? The docs are about the Meteor integration

neutraali commented 5 years ago

No, we're not.

Is there a way to define, config-wise, that we only want to install the default theme?

luki1412 commented 4 years ago

Can confirm that gulp creates themes inside dist/ even though they were not used inside config or are actually disabled. Also, it copies over assets that are disabled for example flags.png gets copied even though i removed the flag component from semantic.json

fomantic / Fomantic-UI

Themes always installed regardless of config #779