should probably have at least a 1x1 matrix

fommil / matrix-toolkits-java

:rocket: High Performance Linear Algebra OOP

GNU Lesser General Public License v3.0

360 stars 104 forks source link

should probably have at least a 1x1 matrix #77

Closed randyp closed 8 years ago

randyp commented 8 years ago

should probably have at least a 1x1 matrix. If we want to test for 0x0 matrix we should do that separately.

The error we saw earlier had to do with the parent test class, SymmEigenvalueTestAbstract, initializing a random 0x0 matrix, A. We were then using the number of rows in A to generate a random int, which threw the exception.

By ensuring that A is at least 1x1 we should avoid random.nextInt(0) problem.

randyp commented 8 years ago

This feels like a temporary fix in place of a more sustainable solution. Is there a discussion group for mtj where I can review and post questions?

fommil commented 8 years ago

No group. I'm actually away for this week so you'll have to look through yourself sorry.