search

fommil / matrix-toolkits-java

:rocket: High Performance Linear Algebra OOP
GNU Lesser General Public License v3.0
362 stars 104 forks source link

Better doc and exceptions for fixed CompMatrices #89

Closed dhutchis closed 8 years ago

dhutchis commented 8 years ago

getIndex throws NullPointerExceptions when the Comp{Row,Col}Matrix classes change their nonzero structure. This is due to Arrays.binarySearch returning an int < -1. This fix provides better documentation and handles this case.

fommil commented 8 years ago

Thanks, but looks like the tests failed. Can you please take a look.

dhutchis commented 8 years ago

It's a problem with .check-diff.sh. Apparently I am not adhering to a code formatting standard. Any idea what that is?

fommil commented 8 years ago

yes, you're not adhering to the code formatting standard :smile:

dhutchis commented 8 years ago

Forgive me for being naive. What is the code formatting standard?

fommil commented 8 years ago

maven enforces it, look in the .travis.yml to see how to apply it.

dhutchis commented 8 years ago

Okay, here you go

fommil commented 8 years ago

cool, thanks!