Replace colors in _layout.scss with SCSS variables

fongandrew / hydeout

A refreshed version of Hyde for Jekyll 3.x and 4.x

https://fongandrew.github.io/hydeout/

Other

594 stars 772 forks source link

Replace colors in _layout.scss with SCSS variables #51

Closed holgerdell closed 6 years ago

holgerdell commented 6 years ago

These edits do not change the way hydeout looks.
The sidebar colors can be changed easily now by changing $sidebar-bg-color and $sidebar-fg-color.
$sidebar-link-color, $sidebar-text-color, $sidebar-title-color, and $sidebar-icon-color are computed from $sidebar-fg-color, but can also be overridden individually if needed.
Previously, some coloring was applied multiple times in _layout.scss - this redundancy is now reduced.
The previous implementation of $sidebar-title-color was broken.

fongandrew commented 6 years ago

Makes sense to me. Thanks again. Heads up that this'll require a major version bump if you're using it as a gem-based dependency. I'll push that out in a bit.

holgerdell commented 6 years ago

Thanks for accepting my PRs! My changes were designed to be backwards compatible, so the version bump was not actually necessary I think.

fongandrew commented 6 years ago

Ah, you're right. Oh well. Thanks again for the PR anyhow.