fongecore / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

Encoder error with quoted phrase in Track Name #167

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Rip and encode Kenny Wayne Shepherd's '10 Days Out'
2.
3.

What is the expected output? What do you see instead?
This disc has titles like 
1. Prison Blues (With Cootie Stark & Neal "Big Daddy" Pattman)
2. Potato Patch (with Jerry "Boogie" McCain)
etc.
All the titles have quotes in them, titles like #2 Are handled fine, but if
there are quotes containing two words with space between, the encoder barfs
with a message like "ERROR: -o/--output-name cannot be used with multiple
files" in the case of Flac, similar with lame. It works just fine if the
space is replaced by a hyphen.

What version of rubyripper are you using? On what operating system? Are you
using the gtk2 or the commandline interface?

gtk2

Please provide any additional information below.

Thanks for the great ripper, the secure ripping along with the ability to
encode multiple formats at once is just fantastic!
-Jim 

Original issue reported on code.google.com by gsf....@gmail.com on 4 Feb 2008 at 3:42

GoogleCodeExporter commented 8 years ago
Yikes, hate errors like that ;) I'll see what I can do.

Original comment by rubyripp...@gmail.com on 6 Feb 2008 at 6:25

GoogleCodeExporter commented 8 years ago
I suggest using the escaping library available at http://www.a-k-r.org/escape/
It is packaged in debian with the name libescape-ruby.

I scratched my own itch and rewrote the flac encoding part with it.

Original comment by hha...@gmail.com on 8 Feb 2008 at 6:18

Attachments:

GoogleCodeExporter commented 8 years ago
Whoops, was missing a space in that patch. 

Original comment by hha...@gmail.com on 8 Feb 2008 at 8:31

Attachments:

GoogleCodeExporter commented 8 years ago
Can you test if current svn has fixed your problem?

Original comment by rubyripp...@gmail.com on 18 Jun 2008 at 4:16

GoogleCodeExporter commented 8 years ago
The SAME bug occurs if the ALBUM name has quotes in it.  

See Bug / Issue 219  (but note the title of the bug is incorrect)

http://code.google.com/p/rubyripper/issues/detail?id=219&q=quotes&sort=-opened&c
olspec=ID%20Type%20Status%20Summary%20Stars%20Opened%20Modified

Original comment by pse.no.s...@gmail.com on 4 Aug 2008 at 3:01

GoogleCodeExporter commented 8 years ago
The bug with quotes in the album name still exists in revision 270 of the svn 
code.  

If there are quotes in the track name, the encoding does suceed but the quotes 
do NOT
appear at all in the final track name.

It looks like rubyripper is stripping the quotes from the track name which in 
my view
is not the best solution.  There is no technical reason why the track name 
cannot
have quotes in it.  You will need to properly escape the spcial characters when
reading and writing the files.

Original comment by pse.no.s...@gmail.com on 4 Aug 2008 at 3:26

GoogleCodeExporter commented 8 years ago
I believe your problem is fixed in svn r298. Please protest if this isn't the 
case.

Original comment by rubyripp...@gmail.com on 7 Aug 2008 at 2:03