fongecore / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

Save logs when encoder error occurs #168

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
When the "only keep logfile if correction is needed" is checked it works as
expected for ripping, but if any of the encoders fail it doesn't keep the
logs.  

I'm ripping my 400+ cd collection and really don't want to pay to much
attention while ripping, I just swap discs while doing other things.  Then
I can just do a search for the dir's that contain ripping.log and deal with
the problem discs after I'm done. In this case it is handy to have it
delete the logs if all goes well, but keep it if there is a ripping or
encoding problem.  I'm including a patch (read note below) that works for
me on 0.50 in case anyone else finds this behavior useful.
-Jim

BIG FAT DISCLAIMER:  My previous programming experience is limited to
"programming" the presets on my car stereo and that time in 1989 when I set
my VCR to record while I was away.  I am not in any way shape or form a
programmer and really don't know what I'm doing. Making this patch was a
learning experience that REALLY pushed the limits of all seven of my brain
cells.  Please consider this carefully before applying this patch as I
cannot be held responsible for any damage your machine may feel compelled
to do should you apply this patch.

Original issue reported on code.google.com by gsf....@gmail.com on 4 Feb 2008 at 3:59

Attachments:

GoogleCodeExporter commented 8 years ago
I see your point. Thanks for reporting. Although the patch may work well, I am
thinking of some other solution than this.

Original comment by rubyripp...@gmail.com on 6 Feb 2008 at 6:24

GoogleCodeExporter commented 8 years ago
I'm sure there's a better way than the way I chose.  Like I said, I'm not a
programmer but it was an interesting learning exercise, and I hate to make a
suggestion without at least making an attempt to contribute something. It's a 
great
program, keep up the good work!
-Jim

Original comment by gsf....@gmail.com on 6 Feb 2008 at 9:24

GoogleCodeExporter commented 8 years ago
Your request is fixed in commit r297.

Original comment by rubyripp...@gmail.com on 7 Aug 2008 at 10:57