fongecore / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

on reripping single tracks from an album, don't delete the other tracks #169

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. rip a whole album
2. log says that one track has errors
3. re rip the track with errors
4. RR asks cancel / delete dir / autorename dir
5. choose delete dir

instead of deleting the whole dir, just overwrite the reripped track (and
then append to the existing log file, maybe).

Original issue reported on code.google.com by dim...@gmail.com on 5 Feb 2008 at 9:39

GoogleCodeExporter commented 8 years ago
Instead of delete dir you should choose autorename. Then manually move the file 
to
the wanted directory. There are too many problems in merging the two 
directories.
The log file for instance should get updated for one particular track! Also the
playlist should get updated if any new tracks are added. If you send me the 
patch
I'll be happy to include it.

Also, how is rubyripper to guess what you want when you press delete dir? I 
suspect
most people expect that the directory will get overwritten when pressing delete
dir. That is exactly what it does. So all in all, this won't get fixed because 
it
ain't broken. It's by design.

Feel free to leave a comment.

Original comment by rubyripp...@gmail.com on 6 Feb 2008 at 6:20

GoogleCodeExporter commented 8 years ago
>>Instead of delete dir you should choose autorename. Then manually move the 
file to
the wanted directory
  Then, you've got a log file (in the first dir) that says the file had errors and
has no reference to the corrected file, or you have to copy the second log file 
into
the first dir (and rename or merge both log files yourself).
>>The log file for instance should get updated for one particular track! 
  I think appending to the end of log file should be fine.  This would show that the
file initally had errors and was reripped correctly.
>>playlist should get updated if any new tracks are added.
  There are no new tracks - the same song is being reripped and the original file
overwritten
>>If you send me the patch I'll be happy to include it.
  I'd love to help, but I'm no programmer.  :)

>>Also, how is rubyripper to guess what you want when you press delete dir? I 
suspect
most people expect that the directory will get overwritten when pressing delete
dir. That is exactly what it does. So all in all, this won't get fixed because 
it
ain't broken. It's by design.

  I agree that the button does what is says it will, but I think the design is
incomplete.    
  "delete directory" has a place for, eg: you re-rip a whole album at a higher mp3
bitrate.  however, you wouldn't want to delete 10 good tracks when you're 
re-ripping
just one of them because it had errors.
  Can you change the design to add an "overwrite files" button for this case?
(including the log-appending feature).

Original comment by dim...@gmail.com on 19 Feb 2008 at 6:57