fongecore / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

Misisng error handling when cdparanoia don't produce a file #180

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Add "-vQ" cmdline param instead of "-Z"
2. Turn on "Verbose" and "Debug"
3. Start rip.

What is the expected output? What do you see instead?

I'd like some error handling instead of a crash. I receive the following
output (in the console).

/rubyripper-0.5.0/rr_lib.rb:664:in `size': No such file or directory -
/home/antzen/Music/Dead Can Dance/temp/track1_1.wav (Errno::ENOENT)
        from /rubyripper-0.5.0/rr_lib.rb:664:in `main'
        from /rubyripper-0.5.0/rr_lib.rb:661:in `times'
        from /rubyripper-0.5.0/rr_lib.rb:661:in `main'
        from /rubyripper-0.5.0/rr_lib.rb:646:in `ripTracks'
        from /rubyripper-0.5.0/rr_lib.rb:634:in `each'
        from /rubyripper-0.5.0/rr_lib.rb:634:in `ripTracks'
        from /rubyripper-0.5.0/rr_lib.rb:629:in `initialize'
        from /rubyripper-0.5.0/rr_lib.rb:629:in `new'
         ... 7 levels...
        from ./rubyripper_gtk2.rb:970:in `initialize'
        from ./rubyripper_gtk2.rb:1083:in `call'
        from ./rubyripper_gtk2.rb:1083:in `main'
        from ./rubyripper_gtk2.rb:1083

What version of rubyripper are you using? On what operating system? Are you
using the gtk2 or the commandline interface?

Original issue reported on code.google.com by Jorgen.H...@gmail.com on 2 Mar 2008 at 12:04

GoogleCodeExporter commented 8 years ago
I suppose you found the magic switches that prevent cdparanoia to actually rip 
the
track. I'll see if I can throw some error message in the main window instead.

Original comment by rubyripp...@gmail.com on 5 Mar 2008 at 6:00

GoogleCodeExporter commented 8 years ago
Fixed in commit 198. After cdparanoia a check is done to ensure that an output 
file
is created. If not, stop the rip and show an error message. Without crashing 
ofcourse.

Original comment by rubyripp...@gmail.com on 5 Mar 2008 at 6:18