Encoder error with quoted phrase in Album Name

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Run Ruby Ripper
2. Insert CD
3. Put quotes in Album Name
(or sometimes CDDB will return an album name with quotes.
e.g.   Symphony No. 9 From "The New World" )

What is the expected output? What do you see instead?

Rips fails when attempting to encode to mp3 etc.

What version of rubyripper are you using? On what operating system? Are you
using the gtk2 or the commandline interface?

rubyripper v0.5.2 
Ubuntu Hardy Heron 8.04.1
gtk2 interface

Please provide any additional information below.

This bug looks similar to bug/issue 167

http://code.google.com/p/rubyripper/issues/detail?id=167&q=quotes&colspec=ID%20T
ype%20Status%20Summary%20Stars%20Opened%20Modified

It looks like rubyripper is not properly escaping special characters before
sending the filename to lame etc

Original issue reported on code.google.com by pse.no.s...@gmail.com on 4 Aug 2008 at 2:56

[GoogleCodeExporter]

TITLE IS WRONG -- 

Should be Encoder error with quoted phrase in ALBUM Name

Original comment by pse.no.s...@gmail.com on 4 Aug 2008 at 2:59

[GoogleCodeExporter]

The bug still occurs when running Revision 270 of the svn code.

To make matters worse, rupyripper gtk does not give any errors.  But when you 
click
Open Directory, you get these errors:

Couldn't find "/home/(my user)/rubbripper-svn/New
Couldn't find "/home/(my user)/rubyripper-svn/World(0)"

The album name I used was 
Synphony No.9, From "The New World"

If you click "Open Log File", my editor opens up with empty info.

Original comment by pse.no.s...@gmail.com on 4 Aug 2008 at 3:20

[GoogleCodeExporter]

The bug with quotes in the album name still exists in revision 270 of the svn 
code.  

If there are quotes in the track name, the encoding does suceed but the quotes 
do NOT
appear at all in the final track name.

It looks like rubyripper is stripping the quotes from the track name which in 
my view
is not the best solution.  There is no technical reason why the track name or 
album
name cannot have quotes in it.  You will need to properly escape the spcial
characters when reading and writing the files.

If possible, please properly escape the album name before passing any info to 
mp3
lame etc encoder and then properly escape any output filename so that the quotes
appear in the album and/or track name.

Original comment by pse.no.s...@gmail.com on 4 Aug 2008 at 3:31

[GoogleCodeExporter]

This should not happen I think. Are you adding the quotes yourself or are they
directly loaded from freedb?

Original comment by rubyripp...@gmail.com on 4 Aug 2008 at 4:11

• Changed title: Encoder error with quoted phrase in Album Name

[GoogleCodeExporter]

They are being directly loaded from freedb.

i.e.  When I insert my CD, freeDB returns this for the album name:
Synphony No.9, From "The New World"

The quotes cause rubyripper / lame to fail to encode the CD and rubyripper does 
nor produce any error 
messages.  If you remove the quotes in the album name, rubyripper / lame  will 
encode the cd properly.

P.S.  You can test and verify this bug simply by adding quotes to ANY album 
name before ripping.

Some other rippers like Sound Juicer do not have problems with quotes in the 
Album name or Track names.  
Sound Juicer will encode the CD into an mp3 etc.

I think you can fix this bug in one of two ways:

1)  Strip all Special Characters and just don't use them.  This is NOT ideal in 
my view.  I prefer to see folders 
and music files with the special characters (like quotes etc).

2)  escape any special characters in the album (and track names) before sending 
the info to an encoder like 
LAME.  (You are probably sending the album name to LAME as part of all the 
metadata for ID3 tags etc).  

Note:  If an encoder cannot handle special characters at all, you will need to 
strip them before sending 
filenames and metadata ID Tag info to the encoder.  But you can still write the 
final folders and mp3 file with 
the special characters simply by renaming the final mp3 produced by the encoder 
via bash etc.

I also don't thnk rubyripper can handle unicode Album  and track names (ie 
names with special characters etc).  
I do hope the developers of rubyripper consider adding unicode support in a 
future version.

Original comment by pse.no.s...@gmail.com on 4 Aug 2008 at 6:35

[GoogleCodeExporter]

I believe your problem is fixed with svn r298.

Original comment by rubyripp...@gmail.com on 7 Aug 2008 at 2:03

• Changed state: Fixed