Crash when choosing to keep defaults

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Insert discs with multiple freedb matches
2. Choose to keep defaults
3. crash

What version of rubyripper are you using? On what operating system? Are you
using the gtk2 or the commandline interface?
svn 307, gtk2, Debian

Please provide any additional information below.

After crash rr would crash on startup until I ejected the disc.  The second
two crashes before were from trying to start with CD still in drive.

Created query string:
/~cddb/cddb.cgi?cmd=cddb+query+04019402+2+150+15035+406&hello=anonymous+my_secre
t.com+rubyripper+0.5.3&proto=6
Multiple hits found
Created fetch string:
/~cddb/cddb.cgi?cmd=cddb+read+Keep+defaults&hello=anonymous+my_secret.com+rubyri
pper+0.5.3&proto=6
/home/user/src/rubyripper/svn/rr_lib.rb:818:in `checkVarArtist': undefined
method `include?' for nil:NilClass (NoMethodError)
    from /home/xxx/src/rubyripper/svn/rr_lib.rb:817:in `times'
    from /home/xxx/src/rubyripper/svn/rr_lib.rb:817:in `checkVarArtist'
    from /home/xxx/src/rubyripper/svn/rr_lib.rb:815:in `each'
    from /home/user/src/rubyripper/svn/rr_lib.rb:815:in `checkVarArtist'
    from /home/user/src/rubyripper/svn/rr_lib.rb:803:in `handleResponse'
    from /home/user/src/rubyripper/svn/rr_lib.rb:723:in `freedbChoice'
    from ./rubyripper_gtk2.rb:1055:in `initialize'
    from ./rubyripper_gtk2.rb:1053:in `new'
    from ./rubyripper_gtk2.rb:1053:in `initialize'
    from ./rubyripper_gtk2.rb:1115:in `call'
    from ./rubyripper_gtk2.rb:1115:in `main'
    from ./rubyripper_gtk2.rb:1115
[user@manger]-(~/src/rubyripper/svn)$ ./rubyripper_gtk2.rb 
/home/user/src/rubyripper/svn/rr_lib.rb:818:in `checkVarArtist': undefined
method `include?' for nil:NilClass (NoMethodError)
    from /home/user/src/rubyripper/svn/rr_lib.rb:817:in `times'
    from /home/user/src/rubyripper/svn/rr_lib.rb:817:in `checkVarArtist'
    from /home/user/src/rubyripper/svn/rr_lib.rb:815:in `each'
    from /home/user/src/rubyripper/svn/rr_lib.rb:815:in `checkVarArtist'
    from /home/user/src/rubyripper/svn/rr_lib.rb:803:in `handleResponse'
    from /home/user/src/rubyripper/svn/rr_lib.rb:640:in `searchMetadata'
    from /home/user/src/rubyripper/svn/rr_lib.rb:621:in `freedb'
    from ./rubyripper_gtk2.rb:174:in `scan_drive'
    from ./rubyripper_gtk2.rb:162:in `initialize'
    from ./rubyripper_gtk2.rb:162:in `new'
    from ./rubyripper_gtk2.rb:162:in `scan_drive'
    from ./rubyripper_gtk2.rb:58:in `initialize'
    from ./rubyripper_gtk2.rb:1114:in `new'
    from ./rubyripper_gtk2.rb:1114
[user@manger]-(~/src/rubyripper/svn)$ ./rubyripper_gtk2.rb 
/home/user/src/rubyripper/svn/rr_lib.rb:818:in `checkVarArtist': undefined
method `include?' for nil:NilClass (NoMethodError)
    from /home/user/src/rubyripper/svn/rr_lib.rb:817:in `times'
    from /home/user/src/rubyripper/svn/rr_lib.rb:817:in `checkVarArtist'
    from /home/user/src/rubyripper/svn/rr_lib.rb:815:in `each'
    from /home/user/src/rubyripper/svn/rr_lib.rb:815:in `checkVarArtist'
    from /home/user/src/rubyripper/svn/rr_lib.rb:803:in `handleResponse'
    from /home/user/src/rubyripper/svn/rr_lib.rb:640:in `searchMetadata'
    from /home/user/src/rubyripper/svn/rr_lib.rb:621:in `freedb'
    from ./rubyripper_gtk2.rb:174:in `scan_drive'
    from ./rubyripper_gtk2.rb:162:in `initialize'
    from ./rubyripper_gtk2.rb:162:in `new'
    from ./rubyripper_gtk2.rb:162:in `scan_drive'
    from ./rubyripper_gtk2.rb:58:in `initialize'
    from ./rubyripper_gtk2.rb:1114:in `new'
    from ./rubyripper_gtk2.rb:1114

Original issue reported on code.google.com by mordbr...@gmail.com on 23 Aug 2008 at 10:57

[GoogleCodeExporter]

I've reverted r307 and suspect your problem is gone. Can you please verify?

Original comment by rubyripp...@gmail.com on 31 Aug 2008 at 11:21

• Changed state: Accepted

[GoogleCodeExporter]

Yes, I can try... but I have totally forgotten which disc did that.  Is there 
any way
to determine from the query string?

Original comment by mordbr...@gmail.com on 31 Aug 2008 at 12:16

[GoogleCodeExporter]

Yup. Move over to freedb.org. Choose advanced search on the right. Then select 
disc-

Original comment by rubyripp...@gmail.com on 31 Aug 2008 at 12:22

[GoogleCodeExporter]

It just keeps telling me to put in a valid disc id... maybe I'm not doing it 
right.

Original comment by mordbr...@gmail.com on 31 Aug 2008 at 12:49

[GoogleCodeExporter]

I've fixed your problem after I could reproduce it. See also:

http://github.com/rubyripperdev/rubyripper/commit/a941d7ec62e18b30996449420a2f85
8dddb

Notice that I've moved over to git, so see the [Git] wikipage to checkout how 
you can
use git.

Original comment by rubyripp...@gmail.com on 31 Aug 2008 at 4:35

• Changed state: Fixed

[GoogleCodeExporter]

Great.  Good news about the move to git, but one question: with svn I always 
knew
which version I was using - but how will I know with git?  Use the sha1 commit 
hash?
 Seems unwieldy and I didn't notice a git command to help.

Original comment by mordbr...@gmail.com on 1 Sep 2008 at 6:23

[GoogleCodeExporter]

You mean like git --help or man git?

But anyway, I'm still finding out myself how stuf works. But the SHA1 thing 
indeed
identifies each commit. But it also got a timestamp ofcourse.

Once cloned, you can easily `git pull` the latest version. `git log` will show 
you
all commits, the latest first.

Original comment by rubyripp...@gmail.com on 1 Sep 2008 at 4:30

[GoogleCodeExporter]

I mean when I'd do svn update it would tell me what commit version I was using. 
 Very
useful for bug reports and I also used that when tagging my flac files (like
comment[10]: ENCODED-BY=cdparanoia III release 10.0 (June 10, 2008) / 
rubyripper svn
307 / flac 1.2.1).  The SHA1 thing is very cumbersome in this case.  I did 
figure out
pull and log, but what about reverting to a previous commit?  Used svn update
--revision 301 and stuff to test if a particular commit broke something and I'm 
not
sure how to do that with git either.

Original comment by mordbr...@gmail.com on 1 Sep 2008 at 8:08

[GoogleCodeExporter]

I've included a link to a manual in the wiki. I guess you will find your answers
there. What I know is that you don't have to specify the whole checksum. Just 
the
first few characters as long as it makes it unique.

Original comment by rubyripp...@gmail.com on 1 Sep 2008 at 8:28

[GoogleCodeExporter]

Ja, I'll check the manual.  Just hoping you already knew.

First unique characters of the checksum should work, but it breaks the 
chronology. 
There is no simple way of knowing if 7881f7910752f458ac29d5034cc677e8bedf77d4 
comes
before or after 5487c440420b49342caca60ce7580a1068a862fd unless you look at the 
log
file.  Fine for now but this will get hard when the log file is bigger.  I've 
an idea
to solve that, I will put in a new request.

Original comment by mordbr...@gmail.com on 1 Sep 2008 at 10:37