Enhancement : protect all %x value in the "Other" field

[GoogleCodeExporter]

Greetings,

My software : Rubyripper, version 0.5.4 in Ubuntu 0810 (Intrepid).

I prefer to use the "Other" field in the "Codecs" tab to have a better
control over lame (i.e. be able to generate both v1 and V2 tags).
My current command line look like :

lame -h -V 2 --vbr-new -m s --add-id3v2 --pad-id3v2 --tt "%t" --ta "%a"
--tl "%b" --ty "%y" --tn "%n" --tg "%g" %i "%o.mp3"

One can notice that some of the vars are protected with quotes (e.g. %t)
and other are not (e.g. %i). In fact, I discovered with trial and error
that RR automatically add quotes for the %i var. 
It would be nice to protect every var this way.

Such protection is required because of specials characters in variables,
such as space.

Thanks by advance

W.

Original issue reported on code.google.com by wizzim@gmail.com on 7 Dec 2008 at 2:29

[GoogleCodeExporter]

An automatic check (and fix) would sure be nice. Shouldn't be too hard to 
implement.

Original comment by rubyripp...@gmail.com on 11 Dec 2008 at 9:42

• Changed state: Accepted

[GoogleCodeExporter]

Fixed in latest commit.

The text of other settings is now first stripped for double quote characters. 
The
quotes are then build up again. It should be monkeyproof now ;)

Original comment by rubyripp...@gmail.com on 11 Dec 2008 at 11:11

• Changed state: Fixed

[GoogleCodeExporter]

So if I understand you well, I can use quotes as I wish : RR will always add 
quotes
where needed ?

If it's the case, this is quite nice ! Many kudos for the improvement :)

Original comment by wizzim@gmail.com on 12 Dec 2008 at 12:38

[GoogleCodeExporter]

Yes :) Feel free to test latest git, see instructions on the wiki here.

Original comment by rubyripp...@gmail.com on 12 Dec 2008 at 7:38

[GoogleCodeExporter]

Hello !

the fix is not working because of the %va option that has two letters :(

Look at rubyripper output and you will understand :
[...]

Extracteur utilisé: cdparanoia 
Vérifications requises pour tous les échantillons: 2
Vérifications requises pour les échantillons erronés: 2

Codec(s) utilisé(s):
-autres -> lame -h -V 2 --vbr-new -m s --add-id3v2 --pad-id3v2  --tt "%t" --ta 
"%v"a
--tl "%b" --ty "%y" --tn "%n" --tg "%g" "%i" "%o".mp3

One should see "%va", not "%v"a...

Original comment by wizzim@gmail.com on 9 May 2009 at 10:04

[GoogleCodeExporter]

Original comment by rubyripp...@gmail.com on 9 May 2009 at 10:42

• Changed state: Accepted

[GoogleCodeExporter]

This is fixed in latest git.

Original comment by rubyripp...@gmail.com on 29 May 2009 at 6:09

• Changed state: Fixed

[GoogleCodeExporter]

Thanks for your support ! It is much appreciated :)

Original comment by wizzim@gmail.com on 29 May 2009 at 6:57