fonic / wcdatool

Watcom Disassembly Tool (wcdatool) - Tool to aid disassembling DOS applications created with the Watcom toolchain
69 stars 7 forks source link

Fix Pył analysis #12

Closed halamix2 closed 1 year ago

halamix2 commented 1 year ago

Polish DOS game Pył (PCGamingWiki, exe) from 1998 currently have issues during the scan:

halamix2 commented 1 year ago

The same TODOs as for fword may apply , as tbyte is defined as unsigned long long + unsigned short

https://github.com/open-watcom/open-watcom-v2/blob/master/bld/wasm/h/tbyte.h

fonic commented 1 year ago

Hi halamix2, thank you for this.

This was bad timing - there is a newer version of wcdatool that I haven't uploaded yet (which both deals with those kind of fixups and adds support for TBYTES). Although I seem to have missed some parts regarding the TBYTES support, I'll check your commits for that.

Could you please test this version first? <deleted, see comment below>

fonic commented 1 year ago

I ported the missing parts from your commit to the new version: wcdatool.zip

Thank you very much, this was a nice addition! Too bad that this version of Pył does not contain debug symbols.

halamix2 commented 1 year ago

Thank you, I'll close this PR then :)