fonini / ckeditor-youtube-plugin

CKEditor Plugin to embed Youtube videos.
https://fonini.github.io/youtube-plugin-for-ckeditor-4.html
Do What The F*ck You Want To Public License
51 stars 61 forks source link

Removed link option and updated German translation. #26

Closed mdoelker closed 10 years ago

mdoelker commented 10 years ago

I've removed the "Include link to YouTube" option in my branch. It is kinda redundant as YouTube offers a button in its player that does exactly the same, with the benefit of pausing the current video and resuming it on their page where you left off. Devices withouth Flash should not be a concern as YouTube offers a HTML5 player. Plus it is not even working at the moment. editor.insertElement only inserts the first element (the video) and discards the appended link tag. Could be fixed by wrapping everything into a <div> or so, but oh well ...

I've also updated the German language file:

fonini commented 10 years ago

I agree. Thanks for the PR! Nice work!