search

fonini / ckeditor-youtube-plugin

CKEditor Plugin to embed Youtube videos.
https://fonini.github.io/youtube-plugin-for-ckeditor-4.html
Do What The F*ck You Want To Public License
51 stars 61 forks source link

fix width and height validation #94

Closed MRoci closed 3 years ago

MRoci commented 3 years ago

use Number() instead of parseInt() to validate user input for height and width properties. Since parseInt stops to the first non-digit and return what it had parsed so far it allows to enter input such as 640" onload="alert()

This closes #89

Sorry for the PR flood :grimacing:

fonini commented 3 years ago

Thanks, @MRoci! You PR's are more than welcome!