fix: change symbol __va_list_tag to __gnuc_va_list for aarch64

foniod / redbpf

Rust library for building and running BPF/eBPF modules

Apache License 2.0

1.71k stars 136 forks source link

fix: change symbol __va_list_tag to __gnuc_va_list for aarch64 #245

Closed ihciah closed 2 years ago

ihciah commented 2 years ago

This PR is to solve #239. There's a problem: When to use __gnuc_va_list and when to use __va_list_tag? I use __gnuc_va_list for aarch64 and arm. I didn't test other arch.

rhdxmr commented 2 years ago

@ihciah DCO (Developer Certificate Origin) is not satisfied so could you fix your commit message to contain Signed-off-by: and re-push with -f?

And don't care about other build-test failures because they are not caused by your commit. Recently the docker images were re-built but they are not configured properly. It will be fixed soon.

bobrik commented 2 years ago

Could you publish a release with these changes?

rhdxmr commented 2 years ago

@bobrik Thanks for asking me this. Sure. I'll prepare new release within few days.