search

foniod / redbpf

Rust library for building and running BPF/eBPF modules
Apache License 2.0
1.71k stars 136 forks source link

Support LLVM14 #316

Open nbaksalyar opened 2 years ago

nbaksalyar commented 2 years ago

This is WIP until llvm-sys is updated to version 140.

Fixes #312.

nbaksalyar commented 2 years ago

llvm-sys v140 has been published now, so this PR is ready to be reviewed.

DerekStrickland commented 2 years ago

Hi @rsdy. I've made some progress this weekend on this issue, but there's more to do. Do you want incremental PRs along the way to get a some improvements earlier rather than later, or do you want one big PR that handles it all? Also, wanted to inform you in advance it will require a PR to build-images to get merged first and for those images to be updated. Looking at previous comments I suspect you expected that though 😄

rsdy commented 2 years ago

@DerekStrickland Thanks for picking this up! I'm happy to merge PRs as they come in assuming that they keep the repo in a consistent state, e.g. if it breaks main "temporarily" I'd much rather merge those PRs together before landing them in main.

I think the best approach might be for you to re-open a different PR with this branch, targeting main, so I can close this and move work over to your fork. Does that make sense?

DerekStrickland commented 2 years ago

Yes it does. I've got a little bit of clean up to do and the work week is back upon us. I'll get some incremental updates over to you as soon as I can starting with the build-images changes that will be required.

AlexGatz commented 2 years ago

Excited about this pr! Thanks for all of the work on it.

DerekStrickland commented 2 years ago

Thanks @AlexGatz. The build-images PR got merged yesterday but failed in the foniod CI while passing in my fork. I'm investigating what is up with that before proceeding to updating RedBPF itself. I'll keep you all posted as I progress.

DerekStrickland commented 2 years ago

@rsdy @AlexGatz New PR staged for build images. tl;dr bindgen published a release that separates the bindgen-cli from the bindgen library via workspace 3 days ago that required a change to the cargo install command.

AlexGatz commented 2 years ago

@rsdy @AlexGatz New PR staged for build images. tl;dr bindgen published a release that separates the bindgen-cli from the bindgen library via workspace 3 days ago that required a change to the cargo install command.

Fantastic. Thank you.

yasin-cs-ko-ak commented 2 years ago

LLVM 15 is released!