fonnymunkey / RLCombat

A fork of Better Combat Rebirth for the modpack RLCraft
3 stars 1 forks source link

Using the opposite hand's sword right after using a sword will cancel that sword's attack out. #7

Closed MagmaBro123 closed 3 months ago

MagmaBro123 commented 1 year ago

Title. This is better explained in video, this does not happen with BetterCombatRebirth.

At 19:00, not quickly using the sword after the mainhand's sword won't cause issues.

Happens with or without other mods.

https://user-images.githubusercontent.com/51277766/224033891-d91d6e34-8fa6-41bc-895f-ce4c908df7c5.mp4

fonnymunkey commented 1 year ago

This is because BetterCombatRebirth's offhand cooldown system was broken, a consequence of reworking it to work properly is that the animation is reset. The attack is not cancelled, nor is the cooldown, its just the animation. I don't have any current plans to try to workaround this since it is just a visual quirk.

MagmaBro123 commented 1 year ago

Ah. Well, could mark this as a todo if needed.

fonnymunkey commented 3 months ago

This will be fixed both with and without custom animations enabled in 2.2.0.