search

fonol / anki-search-inside-add-card

An add-on providing full-text-search and PDF reading functionality to Anki's Add card dialog
https://ankiweb.net/shared/info/1781298089
GNU Affero General Public License v3.0
177 stars 24 forks source link

add-on breaks on 2.1.45 Beta 3 #280

Closed NameLessGO closed 3 years ago

NameLessGO commented 3 years ago

Problems begins at Beta 2

Describe the bug When opening tabs like "Add", "Browser" and "Sync" -> creates conflict with Anki

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Anki/Main Menu'
  2. Click on 'Add'
  3. See error: File "aqt\webview.py", line 41, in cmd File "aqt\webview.py", line 139, in _onCmd File "aqt\webview.py", line 603, in _onBridgeCmd File "aqt\toolbar.py", line 168, in _linkHandler File "aqt\toolbar.py", line 183, in _addLinkHandler File "aqt\main.py", line 1114, in onAddCard File "aqt__init.py", line 101, in open File "aqt\addcards.py", line 48, in init File "aqt\addcards.py", line 60, in setupEditor File "aqt\editor.py", line 111, in init__ File "aqt\editor.py", line 134, in setupWeb KeyError: 'globalKeydown(e); '

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Anki/Main Menu'
  2. Click on 'Browser'
  3. Scroll down to '....'
  4. See error File "aqt\webview.py", line 41, in cmd File "aqt\webview.py", line 139, in _onCmd File "aqt\webview.py", line 603, in _onBridgeCmd File "aqt\toolbar.py", line 168, in _linkHandler File "aqt\toolbar.py", line 186, in _browseLinkHandler File "aqt\main.py", line 1117, in onBrowse File "aqt__init.py", line 101, in open File "aqt\browser\browser.py", line 106, in init File "aqt\browser\browser.py", line 385, in setupEditor File "aqt\editor.py", line 111, in init__ File "aqt\editor.py", line 134, in setupWeb KeyError: 'globalKeydown(e); '

To Reproduce Steps to reproduce the behavior:

  1. Go to ''
  2. Click on 'Sync'
  3. Scroll down to '....'
  4. See error File "aqt\taskman.py", line 101, in _on_closures_pending File "aqt\taskman.py", line 71, in File "aqt\taskman.py", line 90, in wrapped_done File "aqt\sync.py", line 114, in on_future_done File "aqt\main.py", line 964, in on_collection_sync_finished File "aqt\main.py", line 767, in reset File "aqt\main.py", line 719, in _synthesize_op_did_execute_from_reset File "aqt\hooks_gen.py", line 2588, in call File "aqt\browser\browser.py", line 120, in on_operation_did_execute AttributeError: 'Browser' object has no attribute 'editor'

Screenshots If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

Edit breaks with https://ankiweb.net/shared/info/24411424 (Customize Keyboard Shortcuts)

To Reproduce (Customize Keyboard Shortcuts + Searching, PDF Reading & Note-Taking in Add Dialog) Steps to reproduce the behavior:

  1. Go to 'Anki/Main Menu'
  2. Click on 'Browser'
  3. See error: File "aqt\webview.py", line 41, in cmd File "aqt\webview.py", line 139, in _onCmd File "aqt\webview.py", line 603, in _onBridgeCmd File "aqt\toolbar.py", line 168, in _linkHandler File "aqt\toolbar.py", line 186, in _browseLinkHandler File "aqt\main.py", line 1117, in onBrowse File "aqt__init.py", line 101, in open File "aqt\browser\browser.py", line 106, in init__ File "C:\Users\Vidal\AppData\Roaming\Anki2\addons21\24411424\custom_shortcuts.py", line 524, in cs_browser_setupEditor self.editor = Editor(self.mw, self.form.fieldsArea, self) File "aqt\editor.py", line 111, in init File "aqt\editor.py", line 134, in setupWeb KeyError: 'globalKeydown(e); '
fonol commented 3 years ago

Hi, this is a bug introduced by Anki, nothing I can do about it, it will be fixed in the next beta apparently.

NameLessGO commented 3 years ago

Fixed in Beta 5 will close the post, thank you for the attention and for the amazing add-on and support