fonoster / routr

⚡ The future of programmable SIP servers.
https://routr.io
MIT License
1.42k stars 147 forks source link

Fix SIP.js SDP error - update utils.ts with correct SDES parameter #281

Closed SemiConscious closed 4 months ago

SemiConscious commented 4 months ago

Description

Fixed incorrectly encoded SDES parameter in the NG protocol config. SDES parameters are supplied in an array, not a single string. See here: https://github.com/sipwise/rtpengine/issues/433

This cures Failed to set remote offer sdp: SDES and DTLS-SRTP cannot be enabled at the same time. error in SIP.js

See https://github.com/fonoster/routr/issues/280

Type of change

How Has This Been Tested?

I have not been able to test this directly as I don't know how to build the routr-one docker image. However I have built a new docker image based on routr-one:latest with a modified utils.js and this fixes the issue. I was advised by Pedro Sanders that I should submit a pull request and allow the team to perform tests.

Checklist:

psanders commented 4 months ago

@SemiConscious, this is awesome. I'm merging and plan to have a release later today.

SemiConscious commented 4 months ago

@psanders Only too happy :)