search

fonsleenaars / tqdb

Python parser for the Titan Quest Anniversary Edition, Ragnarok, Atlantis, Eternal Ember DLC database.
https://tq-db.net
MIT License
51 stars 15 forks source link

Items are misnamed and links are broken #20

Closed fonsleenaars closed 6 years ago

fonsleenaars commented 6 years ago

@Giant2005 found a list of items (#17) that are misnamed:

Some of the items are misnamed too. Such as the shields: The Glory of Belenus and The Boar of Witham being Battersea Shield and Witham Shield respectively; the helmets: Gutuater Cap and Peak of Leucutius being Waterloo Ceremonial Cap and Peak of Marne respectively; the armors: Brynhild's Belt and Teutoburg Tunic being Shieldmaiden's Belt and Celtic Weapon Coat respectively; the bracelets: Grimhild's Serpents and The Spoils being Spakona Serpent Coils and Bormo's Arm Ring respectively; the swords: Dagger of Basbona and Sword of the Glauberg Prince being Hochdorf Lord's Dagger and Glauberg Prince's Sword respectively; and the boots: Esus' Travelling Boots, Fine Gallic Boots, and Völva's Hardened Wraps being Boots of Esus, Celtic Boots, and Völva's Foot Leathers respectively (As an aside, the link to Völva's Hardened Wraps on the site is broken).

Parser The misnamed items will need to be fixed in the parser. Having the correct names should make it easier to track down where the incorrect names are coming from.

Website The link issue will need to be fixed in the website, allowing links to have more characters now that accents are involved.

fonsleenaars commented 6 years ago

The link issue has been fixed and will be included in the next push.

fonsleenaars commented 6 years ago

@giant2005 I'm taking a look at the naming issues at the moment. The vault you sent me (and one of the examples of misnamed items) was:

[...] The Glory of Belenus [...] being Battersea Shield [...] respectively;

So it should be The Glory of Belenus? That's what the shield is currently called in both the vault and on the website. Or should it be Battersea Shield? I can't find any reference in the game files to Battersea Shield so I'm wondering where that comes from so I can fix it. Unless it's already correct.

It's possible you were seeing a cached version of the tq-db.net website (ctrl+f5 does a full reload, uncached). Or perhaps I'm still missing something ;)

fonsleenaars commented 6 years ago

Looks lik TQ Vault makes the same mistake my parser does, I'll have to dig deeper to find where the names are coming from, I tested it in game with "The Shop" from the workshop and I do see the names you're mentioning (Battersea etc.)

Update: found it, the tags are duplicated:

x2tagUWeapon034=Battersea Shield ... x2tagUWeapon034=The Glory of Belenus

It only saves the last one, I'll have to see if simply checking for an existing tag is enough, or if that messes up other things.