fonsleenaars / tqdb

Python parser for the Titan Quest Anniversary Edition, Ragnarok, Atlantis, Eternal Ember DLC database.
https://tq-db.net
MIT License
50 stars 15 forks source link

Looking for stats no longer works #50

Closed ghost closed 5 years ago

ghost commented 5 years ago

I believe this new optimization thing about only rendering the stuff the user is looking at is the cause of this issue. I would normally ctrl + f on a certain item type page to find whatever stats I'm looking for, but now it gives 0 results most of the time because the item with those stats aren't being rendered.

Example: go to the shields page, and type "reflect" in the ctrl + f search bar. I got 0 results, despite there being several shields that have this stat.

However, I can easily zoom out until every item is visible and then the search works just fine.

fonsleenaars commented 5 years ago

Yeah I ran into this myself while I was developing it. My solution for now is that the search bar at the top is also going to fuzzy search the stats soon.

The optimization kind of forces this behavior as it stands. I'll either find a balance between the two, or otherwise the top search bar will still have the desired functionality.

Thanks for reporting this, I forgot to do so myself while developing the optimized rendering list.

fonsleenaars commented 5 years ago

I've deployed an initial version of property and completion bonus searching to staging (http://staging.tq-db.net)

This means whenever you're on a category page, you can use the top search bar to live search through both names, properties, and completion bonuses now.

So going to Axe and then typing something like "recharge" should list all Axes that give you -% Recharge. It should work on all properties and skills, etc. Once I've tested it a bit I'll deploy it to production.

Hopefully this solves your issue, I'm afraid I couldn't find a good fix for allowing CTRL+F while also optimizing the pages.

fonsleenaars commented 5 years ago

It's been deployed to production with a small release note for v1.2.7. I'll close this issue now but if there's further issues I'll re-open it.