fonsleenaars / tqdb

Python parser for the Titan Quest Anniversary Edition, Ragnarok, Atlantis, Eternal Ember DLC database.
https://tq-db.net
MIT License
51 stars 15 forks source link

Charm - Golem Heart - Statistics of a charm chard instead of completed charm. #95

Closed TheWagi closed 2 years ago

TheWagi commented 3 years ago

Hey o/

There is an issue with the statistics on the "Golem Heart" charms (Normal, Epic, Legendary). The value of the % of chance is the one of a char of charm and not the completed charm like all other charm on the DB.

The % of chance should be 5x the actual one when completed so 50% instead of 10%.

TQDB: https://www.tq-db.net/en/search/golem+heart In-Game:

Wagi

THQ Nordic Moderation

fonsleenaars commented 3 years ago

👍 Thanks for the report!

fonsleenaars commented 2 years ago

Picking this up for the next release, not sure why this one is being weird, the data is showing the correct increment (10% per piece like you said) and it should just be picking off the final value in that case.

defensiveReflectChance,10.000000;20.000000;30.000000;40.000000;50.000000,

Will dig in and fix it for the 1.4.2. release

fonsleenaars commented 2 years ago

Finally figured out what's going on here;

defensiveReflect,30.000000,
defensiveReflectChance,10.000000;20.000000;30.000000;40.000000;50.000000,

My parser incorrectly only sees 1 value for the defensiveReflect property and just grabs the first value for the Chance, instead of inversing the logic and saying "the value is static but the chance is dynamic"

Will be fixed in the upcoming release.