fonsp / Pluto.jl

🎈 Simple reactive notebooks for Julia
https://plutojl.org/
MIT License
5.01k stars 293 forks source link

Logging: use the JULIA_DEBUG ENV value #2509

Open fonsp opened 1 year ago

fonsp commented 1 year ago

With the default logger (in the REPL), you can use the JULIA_DEBUG ENV variable to control the display of @debug logs: https://docs.julialang.org/en/v1/stdlib/Logging/#Environment-variables We should also support this feature in our custom PlutoLogger.

The default implementation is here: https://github.com/JuliaLang/julia/blob/6c2410361a6e413652ed89fb206d4dc6c2af89c9/base/logging.jl#L542 This looks pretty complicated, but maybe there is a way to call this mechanism directly from our code. It might be worth investigating how https://github.com/JuliaLogging/TerminalLoggers.jl did it.

fonsp commented 1 year ago

This would also fix #2487