search

fonsp / Pluto.jl

🎈 Simple reactive notebooks for Julia
https://plutojl.org/
MIT License
4.95k stars 285 forks source link

workspace_custom_startup_expr as String #2654

Closed fonsp closed 12 months ago

fonsp commented 12 months ago

Fix #2652

This change is breaking: session.options.evaluation.workspace_custom_startup_expr now needs to be a String, not an Expr. We believe that this is not too bad since the setting used to be broken (#2652), unless you used Pluto without a web client or built-in HTML export, which is quite rare and probably only happens in PlutoStaticHTML.jl, which uses a version-pinned Pluto dependency.

github-actions[bot] commented 12 months ago

Try this Pull Request!

Open Julia and type:

  julia> import Pkg
  julia> Pkg.activate(temp=true)
  julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="workspace_custom_startup_expr-String")
  julia> using Pluto
rikhuijzer commented 12 months ago

I do wonder whether this actually fixes the situation from https://github.com/fonsp/Pluto.jl/issues/2652? Maybe this just needed better documentation?

fonsp commented 12 months ago

It does fix #2652, Paul found out the cause here https://github.com/fonsp/Pluto.jl/pull/2653#issuecomment-1727187218

fonsp commented 12 months ago

Ah if PlutoStaticHTML is version-pinned then let's just change it without a compat :)