fonsp / Pluto.jl

🎈 Simple reactive notebooks for Julia
https://plutojl.org/
MIT License
4.93k stars 284 forks source link

Factor topology into package: PlutoDependencyExplorer.jl #2717

Closed fonsp closed 7 months ago

fonsp commented 9 months ago

We already did #2698 which means that people can find the references and definitions of an Expr in another package more easily. This PR factors out a second package that layers on top of ExpressionExplorer: given a list of Expr (i.e. a notebook of cells), in which order should the expressions be evaluated?

Not sure about the name PlutoReactiveCore

TODO:

github-actions[bot] commented 9 months ago

Try this Pull Request!

Open Julia and type:

  julia> import Pkg
  julia> Pkg.activate(temp=true)
  julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="PlutoReactiveCore")
  julia> using Pluto
fonsp commented 8 months ago

@quildtide you would like this! Also check out ExpressionExplorer.jl

fonsp commented 7 months ago

@pankgeorg any name suggestions?

fonsp commented 7 months ago

@Pangoraw what do you think about this? It's ready now, but I'm starting to doubt a bit whether the rewriting work and increased complexity was worth it... But I guess it's nice to have this package?

fonsp commented 7 months ago

Yeah that's the thing, I don't have the capacity to use it right away, but I am planning to use it at some point. But I made the split right now so it's best to merge it now before we get conflicts?

pankgeorg commented 7 months ago

Not sure about the name PlutoReactiveCore

It feels that this isn't the reactive core; the reactive core uses the topology that this package outlines IIUC.

I'd call this ReactivityExplorer or DependencyExplorer or TopologyExplorer, following ExpressionExplorer or something

fonsp commented 7 months ago

Hmm but I like to keep Pluto in the name I think... because this package is more Pluto-specific and opinionated than ExpressionExplorer. Maybe PlutoDependencyExplorer?

fonsp commented 7 months ago

yolooo