search

fonsp / Pluto.jl

🎈 Simple reactive notebooks for Julia
https://plutojl.org/
MIT License
4.93k stars 284 forks source link

Cannot download notebook file from static html export #2728

Closed fonsp closed 8 months ago

fonsp commented 9 months ago

Click Edit or Run, then download the notebook file:

https://j-fu.github.io/PlutoVista.jl/dev/plutovista.html

fonsp commented 8 months ago

It's because clicking the <a> is accidentally considered as a light dismiss of the <dialog>, triggering

https://github.com/fonsp/Pluto.jl/blob/b6998a32d1e2b12f2b86c4a3d7f5ae6eef5a6e5e/frontend/common/useDialog.js#L27

Notice that clicking anywhere on the dialog causes it to close :(

fonsp commented 8 months ago

Fixed it by removing the light_dismiss option on dialogs, I found it too tricky to implement correctly.

We won't be able to fix old Pluto exports unfortunately...