search

fonsp / Pluto.jl

🎈 Simple reactive notebooks for Julia
https://plutojl.org/
MIT License
4.96k stars 286 forks source link

fix(dialogs): backward compatible dialog usage #2816

Closed pankgeorg closed 7 months ago

pankgeorg commented 7 months ago

There is an issue in Firefox 91 where the close() method is being called but it also doesn't exists (which is weird because it should have been polyfilled).

This may be a race condition though.

In any case, the optional chaining of a function call should be invoked with ?.(), to guard for null up the chain.

We also only call the polyfill when the element is not there and we guard the method calls vs the open attribute.

github-actions[bot] commented 7 months ago

Try this Pull Request!

Open Julia and type:

  julia> import Pkg
  julia> Pkg.activate(temp=true)
  julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="pg/modal-fix")
  julia> using Pluto