search

fonsp / Pluto.jl

🎈 Simple reactive notebooks for Julia
https://plutojl.org/
MIT License
4.91k stars 284 forks source link

Autocomplete: select completion with comma key #2871

Closed fonsp closed 3 months ago

fonsp commented 3 months ago

Typing funcs = [sin, identi<COMMA> should autocomplete to funcs = [sin, identity,

fonsp commented 3 months ago

Same with (

kosukesando commented 1 month ago

I'm having trouble with this behaviour being overzealous, for example when I just want to iterate over zip'd iterables:

for (f,b) in zip(foo,bar)

typing in for (f<COMMA> will instantly autocomplete this with some arbitrary variable that has nothing to do with this code block. I think there's been other occurrences of this but can't give off the top of my head right now.

kosukesando commented 1 month ago

It's also doubly annoying when I can't ESC out of the autocomplete back to the cell, but it takes me out of the autocomplete AND the cell. (please excuse the double comment, it probably belongs somewhere else)

fonsp commented 1 month ago

Thanks! What browser do you use?

kosukesando commented 1 month ago

Firefox(126.0) on Windows 10, running Julia+Pluto on Ubuntu(WSL2).

fonsp commented 1 month ago

Can you check if the ESC issue also exists on Chrome if you have it installed?

fonsp commented 1 month ago

Fixed the comma thing in https://github.com/fonsp/Pluto.jl/commit/3af53f9cbc550315ced9fefc7d2e5cd1a22d06ef

fonsp commented 1 month ago

Can you check if the ESC issue is also there on Pluto#main? I can't reproduce on firefox. If so, could you make a new issue?

kosukesando commented 1 month ago

Thanks for the quick response! I tried Chrome, it turns out the ESC issue was just Vimium, my bad. The comma thing was present in both FF and Chrome. For the time being I can just deal with the autocomplete with hitting ESC.