fonsp / Pluto.jl

🎈 Simple reactive notebooks for Julia

https://plutojl.org/

MIT License

5k stars 296 forks source link

Stack trace URL improvements #3038

Open fonsp opened 1 month ago

fonsp commented 1 month ago

New features:

Clickable URLs for functions from packages (thanks to @adrhill !!)
Show package name for external functions
Icon to show that the link will open in a new tab
Some CSS tweaks

Example

github-actions[bot] commented 1 month ago

Try this Pull Request!

Open Julia and type:

  julia> import Pkg
  julia> Pkg.activate(temp=true)
  julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="stack-frame-url-imrpvoements")
  julia> using Pluto

fonsp commented 1 month ago

The new URL code does not work on Julia 1.6, and I don't see an easy way to make it work :(

fonsp commented 1 month ago

It might be worth trying this code https://github.com/JuliaLang/julia/issues/47709#issuecomment-2388629772 ? RegistryInstances might be okay to add as a dep

cstjean commented 4 days ago

The clickable URL feature is what I'm talking about in https://github.com/fonsp/Pluto.jl/issues/2737#issuecomment-2450879776. I would selfishly prefer JULIA_EDITOR over an URL because

It works even if offline
It works for local packages
It's always pointing to the right line, even for old versions.
My editor is comfier than github.

I know you favor simplicity and what's-best-for-students, so I'm not going to get my hopes up. This PR as is looks great!

fonsp commented 3 days ago

I think launching an editor doesnt fit our target audience

cstjean commented 1 hour ago

I think launching an editor doesnt fit our target audience

Yes, that's what I thought you would say 🙂. Oh well! I agree that for students the URL works out better.

You could in theory favor JULIA_EDITOR if it's defined (since it's undefined by default) and fallback to the URL, but it's ugly logic and complexity.