fonsp / Pluto.jl

🎈 Simple reactive notebooks for Julia
https://plutojl.org/
MIT License
4.98k stars 294 forks source link

Binder not working #3070

Open fonsp opened 4 days ago

fonsp commented 4 days ago

Binder is not working for Pluto 0.20 and 0.20.1:

image

I think the jupyter-server-proxy extension is not working (404 means that the proxy did nothing).

My guess is that the binder base image has a new version of jupyterlab or notebook or sth and jsp is no longer compatible.

Changelogs show this: https://github.com/jupyterhub/jupyter-server-proxy/blob/main/docs/source/changelog.md (we use 1.5.1 right now).

Here is the fork we use: http://github.com/fonsp/jupyter-server-proxy and the setup file where this is specified: https://github.com/fonsp/pluto-on-binder/blob/master/setup.py

I also recently found out about https://github.com/yuvipanda/jupyter-pluto-proxy which might be a good place to start over!

The reason we have a fork of jsp is to allow CORS websocket requests. You can see this in the diff of my fork:

https://github.com/jupyterhub/jupyter-server-proxy/compare/main...fonsp:jupyter-server-proxy:master

fonsp commented 1 day ago

I updated the fork based off jsp 4.4.1. New fork: https://github.com/jupyterhub/jupyter-server-proxy/compare/main...fonsp:jupyter-server-proxy:okt-2024

Updating pluto-on-binder: https://github.com/fonsp/pluto-on-binder/pull/22

fonsp commented 1 day ago

It works!!!

fonsp commented 1 day ago

Owww but now it crashed while loading the notebook

image

It happens while the PlutoRunner boot env is instantiating, let me try moving that to the binder build phase.