search

fonsp / Pluto.jl

🎈 Simple reactive notebooks for Julia
https://plutojl.org/
MIT License
4.94k stars 285 forks source link

UndefVarError: Pkg not defined for Pluto v0.12.8 #662

Closed lungben closed 3 years ago

lungben commented 3 years ago

Hi Fons,

I just upgraded to Pluto v0.12.8 and got the error message UndefVarError: Pkg not defined in my notebooks. They have been running fine in Pluto v0.12.7 and until yesterday in the built-in-tables branch.

As example, the sample notebook suggested here: #652

image

fonsp commented 3 years ago

Very strange, it only happens on master, but not on #646 . Also can't repoduce in tests

It looks like an extra workspace is created without the usings:

image

fonsp commented 3 years ago

It only happens when you run the notebook directly, not when you start running the notebook in the background from the main menu 🤷‍♀️ Opening the same notebook in multiple tabs while it is loading creates even more workspaces

fonsp commented 3 years ago

Ah I think I have it 😚 The notebook's workspace is being requested multiple times while it is still being created - race condition

fonsp commented 3 years ago

@hdrake This is probably the same issue that you mentioned yesterday

hdrake commented 3 years ago

@hdrake This is probably the same issue that you mentioned yesterday

Yeah, it looks like it.

fonsp commented 3 years ago

Fixed in https://github.com/fonsp/Pluto.jl/commit/acf989502fdca93692d440e8d7769daaee89f50d - you can upgrade to 0.12.9 in 30 minutes

lungben commented 3 years ago

Thanks!