search

fontIconPicker / react-fonticonpicker

React FontIconPicker Component to pick icon or SVG from a selection.
https://fonticonpicker.github.io/react-fonticonpicker/
MIT License
31 stars 33 forks source link

added closeOnSelect prop and tests #6

Closed davidgolden closed 5 years ago

davidgolden commented 5 years ago

added optional prop 'closeOnSelect' which when true closes dropdown icon picker when an icon is selected. also added associated tests.

codecov[bot] commented 5 years ago

Codecov Report

Merging #6 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files           8        8           
  Lines         284      284           
  Branches       63       63           
=======================================
  Hits          279      279           
  Misses          4        4           
  Partials        1        1
Impacted Files Coverage Δ
src/js/components/FontIconPicker.jsx 94.28% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 230de9e...b483ca9. Read the comment docs.

swashata commented 5 years ago

Thank you. I will review it earliest tomorrow and will get it merged 😃

swashata commented 5 years ago

I have released a new version 1.2.0. 👍