search

fontello / brandico.font

Font with logos of social services & messagers
http://fontello.github.io/brandico.font/demo.html
299 stars 63 forks source link

Add Amex, Discover, Visa & Mastercard icons #11

Closed ricburton closed 10 years ago

ricburton commented 10 years ago

Added the SVGs and updated the config file.

puzrin commented 10 years ago

Hm... are you shure about images? Those looks very strange:

I'd say, nobody will understand what are those icons about.

ricburton commented 10 years ago

Apologies—not sure where I went wrong. I'll try submitting a new pull request.

ricburton commented 10 years ago

So I think running make dump is what destroyed the images (here's the before and after):

visa before visa after

I'm exporting my SVGs from Sketch App—could that be the root of the problem?

puzrin commented 10 years ago

Original images should be placed into svg/orig folder. Other things are auto-generated.

Or just send me right svg images to vitaly@rcdesign.ru and i'll care about technical details.

ricburton commented 10 years ago

Yeah. I'm placing the SVGs there and then running make dump from the root folder. I'll send along the images now but it'd be interesting to know where I'm going wrong.

Thanks!

puzrin commented 10 years ago

originals in repo were not ok.

puzrin commented 10 years ago

http://fontello.github.io/brandico.font/demo.html

Fixed images. Can publish soon, after close a couple if similar pending requests.

Can't say, those logos are perfect in small size. Consider release next version with improvements (that will not postpone publishing):

  1. IMHO, it worth to use full height (1000px), instead if fitting width.
  2. Ameciran express - white letters instead of double countoured. Probably just "AMEX"
  3. Discover - more fat letters.

Try to check result visually - rescale images to 20px in editor, and check if details are not completely blured.

ricburton commented 10 years ago

Apologies in the delay to respond here. They're definitely not suited to 20px, I agree. I've been playing with some simpler icons but it doesn't look great: http://cl.ly/image/2r2o22033F2x

Any thoughts?

The tricky part with making the designs full height would skew the card shape vertically and it wouldn't represent a credit card. Perhaps my icons only look best when they're slightly larger: http://rb.cm/brandfont/

Richard

On 10 February 2014 13:53, Vitaly Puzrin notifications@github.com wrote:

http://fontello.github.io/brandico.font/demo.html

Fixed images. Can publish soon, after close a couple if similar pending requests.

Can't say, those logos are perfect in small size. Consider release next version with improvements (that will not postpone publishing):

  1. IMHO, it worth to use full height (1000px), instead if fitting width.
  2. Ameciran express - white letters instead of double countoured. Probably just "AMEX"
  3. Discover - more fat letters.

Try to check result visually - rescale images to 20px in editor, and check if details are not completely blured.

Reply to this email directly or view it on GitHubhttps://github.com/fontello/brandico.font/pull/11#issuecomment-34687253 .

puzrin commented 10 years ago

I'm not designer, can't comment details how to improve.